Feature: 7702 Transaction Support#88
Conversation
|
@KartikSoneji is attempting to deploy a commit to the joshaavecom's projects Team on Vercel. A member of the Team first needs to authorize it. |
joshstevens19
left a comment
There was a problem hiding this comment.
thanks for PR just 1 comment
| Transaction { | ||
| id: row.get("id"), | ||
| relayer_id: row.get("relayer_id"), | ||
| authorization_list: row.get("authorization_list"), |
There was a problem hiding this comment.
i dont see anything in the schema https://github.com/KartikSoneji/rrelayer/tree/feature/7702-support/crates/core/src/schema so this field doesnt exist - you need to create a v1_0_3.rs one to add this field with defaults NULL so other upgrade using this still work
There was a problem hiding this comment.
Ah missed that, pushed a commit to add it.
rrelayer/crates/core/src/schema/v1_0_3.rs
Lines 3 to 13 in d045db1
joshstevens19
left a comment
There was a problem hiding this comment.
just need to actually save the authorization_list when your sending tx or replacing it etc i cant see you changing that bit of code?
| Transaction { | ||
| id: row.get("id"), | ||
| relayer_id: row.get("relayer_id"), | ||
| authorization_list: row.get("authorization_list"), |
There was a problem hiding this comment.
i dont see where you save this when you send a transaction ?
There was a problem hiding this comment.
Ah ok I think it needs a few more changes.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Adds support for 7702 transactions via an optional
authorizationListparameter in send transaction.closes #87