Skip to content

feat: add banks list for en_GB locale - #2363

Merged
fcurella merged 1 commit into
joke2k:masterfrom
osolomientsev:master
Jun 2, 2026
Merged

feat: add banks list for en_GB locale#2363
fcurella merged 1 commit into
joke2k:masterfrom
osolomientsev:master

Conversation

@osolomientsev

Copy link
Copy Markdown
Contributor

What does this change

Adds a banks tuple to the en_GB bank provider, enabling the bank() method to return realistic UK bank names. Also adds a test_bank test to the TestEnGb class in tests/providers/test_bank.py.

What was wrong

The en_GB bank provider was missing the banks attribute, causing bank() to raise AttributeError despite being documented as supported for this locale.

How this fixes it

Added a banks tuple containing major UK retail banks, challenger banks, and Islamic banks. Sources:

Fixes #2280

AI Assistance Disclosure (REQUIRED)

  • If AI tools were used, I have disclosed which ones, and fully reviewed and verified their output.

Claude (Anthropic) was used to assist with compiling the initial bank list. The list was cross-referenced against Wikipedia sources and verified manually.

Checklist

  • I have read the documentation about CONTRIBUTING
  • I have read the documentation about Coding style
  • I have run make lint

@reory

reory commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

"Hi @osolomientsev!
I previously worked on this exact issue (PR #2332) and it's great to see it being pushed forward with tests and a more comprehensive list including challenger banks. The logic looks solid—happy to see en_GB finally getting its bank provider!" 😁

@fcurella fcurella left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcurella
fcurella merged commit fbd8c03 into joke2k:master Jun 2, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

en_GB locale claims to support the bank method, but does not

3 participants