Open
Conversation
Adds 15 providers for the mk_MK locale: - address: cities, streets, regions, postal codes, countries (195 countries) - automotive: license plates in XX NNNN YY format with all 34 official regional codes - bank: IBAN with MK country code, 14 real Macedonian banks - color: 40 color names in Macedonian Cyrillic - company: company names with Macedonian legal suffixes (АД, ДОО, ДООЕЛ…) - currency: currency names in Macedonian - date_time: month and day names in Macedonian - geo: coordinates bounded to North Macedonia's geographic extent - internet: emails with .mk TLD, Cyrillic→ASCII transliteration - job: 72 job titles in Macedonian - lorem: 200+ common Macedonian words - passport: Macedonian passport number format - person: male/female first/last names with gender suffixes - phone_number: Macedonian mobile and landline formats - ssn: EMBG (13-digit national ID) with MOD-11 checksum
fcurella
requested changes
Mar 23, 2026
|
|
||
|
|
||
| class Provider(PersonProvider): | ||
| """Person provider for mk_MK locale (Macedonian).""" |
Collaborator
There was a problem hiding this comment.
Do you have an authoritive source for these names?
Author
There was a problem hiding this comment.
This is the State Statistical Office page: https://www.stat.gov.mk/Iminja_Preziminja.aspx
. On this page you can find how many people have the given name or surname. Alternatively, this page may also be useful: https://www.behindthename.com/names/usage/macedonian
. If that’s OK, I can update the class docstring with one of these links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mk_MK(Macedonian) locale support with 15 providers covering address, automotive, bank, color, company, currency, date_time, geo, internet, job, lorem, passport, person, phone_number, and SSN (EMBG)Providers added
addressautomotiveXX NNNN YYformat, all 34 official regional codes (Wikipedia)bankMKIBAN country code, 14 real banks (Wikipedia list)colorcompanycurrencydate_timegeointernet.mkTLD, Cyrillic→ASCII transliteration for usernamesjoblorempassportpersonphone_numberssnTest plan
make lint(flake8, black, isort) — cleanmypy— no errors (724 source files)TestMkMktests — all pass