Show human-readable status labels in CLI device tables - #91
Open
valentinocossar wants to merge 1 commit into
Open
Show human-readable status labels in CLI device tables#91valentinocossar wants to merge 1 commit into
valentinocossar wants to merge 1 commit into
Conversation
valentinocossar
force-pushed
the
fix/cli-status-labels
branch
from
August 24, 2026 10:48
52f6a4d to
4b9e0ca
Compare
format_device_status() was interpolating the raw Status enum value (e.g. "update_available") straight into Rich markup instead of a readable label, unlike every other column in the same table. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VApHaH9KZ6BPV9SwvUAVLH
valentinocossar
force-pushed
the
fix/cli-status-labels
branch
from
August 24, 2026 10:50
4b9e0ca to
d3cb903
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
format_device_status()inpackages/cli/src/cli/presentation/styles.pywas interpolating the rawStatusenum value (e.g.update_available,no_update_needed) straight into Rich markup, unlike every other column in the same tables which is already humanized (Unknown/N/Afallbacks, friendly success/warning messages).Statusvalues (reusing the same wording already used on the web frontend'sstatus.*i18n namespace where they overlap) and aget_device_status_label()helper, used byformat_device_status()alongside the existing color logic._format_discovered_devices_table,_format_legacy_device_table,commands/common.py::format_device_table) since they all funnel throughformat_device_status().packages/cli/tests/unit/presentation/test_styles.py), previously only exercised indirectly.Test plan
shelly-manager scan <range>andshelly-manager device list <range>— verified against real devices on both commands, Status column shows "Update Available", "Up to Date", "Detected", etc. instead of raw enum strings🤖 Generated with Claude Code
https://claude.ai/code/session_01VApHaH9KZ6BPV9SwvUAVLH