Show friendly model names for discovered devices - #89
Merged
Conversation
Map Shelly model IDs to their marketing names (sourced from aioshelly's table) and surface them wherever the raw SKU was shown: the dashboard model column, the device detail header, and the CLI device tables. Unmapped models fall back to the raw model ID, so new hardware renders exactly as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Show friendly Shelly model names (Shelly Plus 2PM) instead of raw SKUs (SNSW-102P16EU) in the dashboard table, the device detail page, and CLI tables.
Context
Closes #78. The model to marketing name mapping is vendored from aioshelly's table (150 models, Gen1 through Gen4). Unknown models fall back to the raw model ID, so new hardware renders exactly as before. The Model column filters and sorts on both the friendly name and the raw ID since both are visible.
Notes