Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 31 additions & 15 deletions pkg/config/app_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func NewAppConfig(
})
} else {
// Load default config files
path := filepath.Join(configDir, ConfigFilename)
_, path := findConfigFile(ConfigFilenames)
configFile := &ConfigFile{Path: path, Policy: ConfigFilePolicyCreateIfMissing}
configFiles = []*ConfigFile{configFile}
}
Expand Down Expand Up @@ -125,7 +125,7 @@ func NewAppConfig(
}

func ConfigDir() string {
_, filePath := findConfigFile(ConfigFilename)
_, filePath := findConfigFile(ConfigFilenames)

return filepath.Dir(filePath)
}
Expand Down Expand Up @@ -585,34 +585,50 @@ func (c *AppConfig) GetTempDir() string {

// findConfigFile looks for a possibly existing config file.
// This function does NOT create any folders or files.
func findConfigFile(filename string) (exists bool, path string) {
func findConfigFile(filenames []string) (exists bool, path string) {
if envConfigDir := os.Getenv("CONFIG_DIR"); envConfigDir != "" {
return true, filepath.Join(envConfigDir, filename)
return findFirstConfigFile(filenames, envConfigDir)
}

// look for jesseduffield/lazygit/filename in XDG_CONFIG_HOME and XDG_CONFIG_DIRS
legacyConfigPath, err := xdg.SearchConfigFile(filepath.Join("jesseduffield", "lazygit", filename))
if err == nil {
return true, legacyConfigPath
for _, filename := range filenames {
legacyConfigPath, err := xdg.SearchConfigFile(filepath.Join("jesseduffield", "lazygit", filename))
if err == nil {
return true, legacyConfigPath
}
}

// look for lazygit/filename in XDG_CONFIG_HOME and XDG_CONFIG_DIRS
configFilepath, err := xdg.SearchConfigFile(filepath.Join("lazygit", filename))
if err == nil {
return true, configFilepath
for _, filename := range filenames {
configFilepath, err := xdg.SearchConfigFile(filepath.Join("lazygit", filename))
if err == nil {
return true, configFilepath
}
}

return false, filepath.Join(xdg.ConfigHome, "lazygit", filename)
return false, filepath.Join(xdg.ConfigHome, "lazygit", filenames[0])
}

// findFirstConfigFile returns the first existing file in dir from the list, or
// the default path if none exist.
func findFirstConfigFile(filenames []string, dir string) (exists bool, path string) {
for _, filename := range filenames {
fullPath := filepath.Join(dir, filename)
if _, err := os.Stat(fullPath); err == nil {
return true, fullPath
}
}
return false, filepath.Join(dir, filenames[0])
}

var ConfigFilename = "config.yml"
var ConfigFilenames = []string{"config.yml", "config.yaml"}

// stateFilePath looks for a possibly existing state file.
// if none exist, the default path is returned and all parent directories are created.
func stateFilePath(filename string) (string, error) {
exists, legacyStateFile := findConfigFile(filename)
if exists {
return legacyStateFile, nil
_, path := findFirstConfigFile([]string{filename}, xdg.ConfigHome+"/lazygit")
if _, err := os.Stat(path); err == nil {
return path, nil
}

// looks for XDG_STATE_HOME/lazygit/filename
Expand Down