Skip to content

Set label on metal load balancer to allow dns#292

Merged
gonzolino merged 1 commit intomainfrom
fix/dns
Mar 19, 2026
Merged

Set label on metal load balancer to allow dns#292
gonzolino merged 1 commit intomainfrom
fix/dns

Conversation

@gonzolino
Copy link
Copy Markdown
Contributor

@gonzolino gonzolino commented Mar 19, 2026

Proposed Changes

  • Allow metal-load-balancer-controller-manager to talk to the cluster dns

Summary by CodeRabbit

  • Chores
    • Added DNS traffic allowance label to the metal load balancer controller manager deployment configuration.

@github-actions github-actions bot added size/XS bug Something isn't working labels Mar 19, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d278079a-5710-40f2-a675-3d1c4409916c

📥 Commits

Reviewing files that changed from the base of the PR and between 4a782f7 and 2af3b3e.

📒 Files selected for processing (1)
  • charts/internal/seed-controlplane/charts/metal-load-balancer-controller-manager/templates/deployment.yaml

Walkthrough

A single pod label networking.gardener.cloud/to-dns: allowed was added to the metal-load-balancer-controller-manager deployment template in the Helm chart. No functional logic or configuration changes were made.

Changes

Cohort / File(s) Summary
Kubernetes Deployment Label
charts/internal/seed-controlplane/charts/metal-load-balancer-controller-manager/templates/deployment.yaml
Added network policy label to pod template metadata for DNS networking policy enforcement.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding a DNS-related label to the metal load balancer deployment.
Description check ✅ Passed The description covers the key proposed change but lacks detail in other sections. Only one bullet point provided instead of multiple.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dns
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gonzolino gonzolino merged commit b3475ee into main Mar 19, 2026
10 checks passed
@gonzolino gonzolino deleted the fix/dns branch March 19, 2026 14:57
@hardikdr hardikdr added the area/gardener-extension Gardener extension integration. label Mar 20, 2026
@hardikdr hardikdr added this to Roadmap Mar 20, 2026
@github-project-automation github-project-automation bot moved this to Done in Roadmap Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/gardener-extension Gardener extension integration. bug Something isn't working size/XS

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants