[GEP-28] Use technicalID from Cluster instead of Worker.Namespace#265
Merged
Nuckal777 merged 1 commit intoironcore-dev:mainfrom Nov 21, 2025
Merged
[GEP-28] Use technicalID from Cluster instead of Worker.Namespace#265Nuckal777 merged 1 commit intoironcore-dev:mainfrom
Cluster instead of Worker.Namespace#265Nuckal777 merged 1 commit intoironcore-dev:mainfrom
Conversation
9 tasks
Nuckal777
reviewed
Nov 21, 2025
|
|
||
| machineClassProviderSpec[metal.LabelsFieldName] = map[string]string{ | ||
| metal.ClusterNameLabel: w.cluster.ObjectMeta.Name, | ||
| metal.ClusterNameLabel: w.cluster.Shoot.Status.TechnicalID, |
Contributor
Author
There was a problem hiding this comment.
So far, w.cluster.ObjectMeta.Name has always been the technical ID (shoot--foo--bar). Now, it could also be kube-system for self-hosted shoots with managed infrastructure. So, I assume that the label value should keep its value – also if you ever want to bootstrap self-hosted shoots :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
To support self-hosted shoots with managed infrastructure, the
Workercontroller/delegate needs to use the technical ID fromCluster.shoot.status.technicalIDfor prefixing the names of machine-related objects. TheWorkernamespace iskube-systemfor self-hosted shoots.This PR is similar to gardener/gardener@
22f4295(#13485).Part of gardener/gardener#13485