[several] Refactor, stage 2, take 2#185
Open
SwooshyCueb wants to merge 41 commits intoirods:mainfrom
Open
Conversation
Member
Author
|
At present, this PR establishes an AMQP connection just fine, but doesn't actually send any messages. I think this is because the thread with the proton container gets left behind when the agent forks. Might have to use IPC. |
SwooshyCueb
force-pushed
the
refactor2.m
branch
from
df5c652 to
3a90467
Compare
Closed
SwooshyCueb
force-pushed
the
refactor2.m
branch
10 times, most recently
from
3d761cc to
43b0f51
Compare
SwooshyCueb
force-pushed
the
refactor2.m
branch
from
aceebce to
87af655
Compare
korydraughn
reviewed
Mar 18, 2026
Contributor
korydraughn
left a comment
korydraughn
left a comment
There was a problem hiding this comment.
Feel free to address these review comments after you get things working.
SwooshyCueb
force-pushed
the
refactor2.m
branch
3 times, most recently
from
6d756aa to
ace23d3
Compare
SwooshyCueb
force-pushed
the
refactor2.m
branch
9 times, most recently
from
41038a1 to
abbb5d9
Compare
Contributor
|
Will this work require the admin to change their plugin configuration? If so, in what way? |
SwooshyCueb
force-pushed
the
refactor2.m
branch
from
15af67f to
08fa34d
Compare
SwooshyCueb
force-pushed
the
refactor2.m
branch
3 times, most recently
from
579b21e to
4fadc2a
Compare
SwooshyCueb
force-pushed
the
refactor2.m
branch
from
4fadc2a to
8719452
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #113
Addresses #106
Addresses #109
Addresses #163
Addresses #164
Addresses #183
Addresses #184
Addresses #186