refactor(tests): simplify HostSlice conversion in ecntt test#1022
Open
crStiv wants to merge 1 commit intoingonyama-zk:mainfrom
Open
refactor(tests): simplify HostSlice conversion in ecntt test#1022crStiv wants to merge 1 commit intoingonyama-zk:mainfrom
crStiv wants to merge 1 commit intoingonyama-zk:mainfrom
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have hereby read the ICICLE CLA and agree to its terms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes
This PR simplifies the call to ecntt in tests.rs by removing an unnecessary conversion using HostSlice::from_slice(...). The slice is now passed directly using .into_slice().
Describe the rational
The change reduces code complexity by eliminating redundant wrapping of the slice. The simplified call improves readability and makes the test code easier to maintain.
Backend branches
Replace "main" with the branch this PR should work with
cuda-backend-branch: main
metal-backend-branch: main