Skip to content

Fi 3620 use shc test#19

Open
bmeshell wants to merge 12 commits intomainfrom
FI-3620-use-shc-test
Open

Fi 3620 use shc test#19
bmeshell wants to merge 12 commits intomainfrom
FI-3620-use-shc-test

Conversation

@bmeshell
Copy link
Copy Markdown
Contributor

Summary

Refactored SHC vaccination test kit to:

  • Remove health_card dependency
  • Rename modules, IDs, etc. from COVID19 to the more general shc_vaccination
  • Use existing tests from Smart Health Cards Test Kit

Testing Guidance

Run in browser with
bundle exec inferno services start
bundle exec inferno start
Test using health_cards project as a reference server

@bmeshell bmeshell requested a review from yunwwang January 20, 2025 23:23
Comment thread lib/shc_vaccination_test_kit.rb Outdated
Comment thread lib/shc_vaccincation/vc_fhir_validation.rb Outdated
@yunwwang
Copy link
Copy Markdown
Contributor

yunwwang commented Jan 21, 2025

Please update

  • README.md (see the README.md in SHC)
  • The ig in the lib/shc_vaccination/igs should be replaced by the one from 1.0.0-ballot: https://build.fhir.org/ig/HL7/fhir-shc-vaccination-ig/downloads.html
  • Rename vc_fhir_validation.rb to shc_vaccination_fhir_validation.rb
  • Add description to shc_vaccination_fhir_validation (see corresponding one in SHC)
  • Update test id for shc_vaccination_fhir_validation

id :shc_vaccination_fhir_validation
title 'Health Card payloads conform to the Vaccination Credential Bundle Profiles'
description %(
SMART Health Card (SHC) for vaccination records payload SHALL be a valid FHIR Bundle resource
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SMART Health Card (SHC) for vaccination records payload SHALL be a valid FHIR Bundle resource
SMART Health Card (SHC) for vaccination records payload SHALL be a valid [Fullback (AD) Bundle](https://build.fhir.org/ig/HL7/fhir-shc-vaccination-ig/bundles.html) resource

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants