Conversation
- Add inception-dist-win module producing an x86_64 Windows MSI installer via jpackage, mirroring the structure of inception-dist-macos (single module, dist-win profile, scripts under src/main/scripts/). - Drive jpackage from package-msi.sh with explicit jdk.x86_64.home lookup; native-arch builds fall back to JAVA_HOME, cross-arch builds skip with a warning when no JDK is configured. - Strip foreign-platform native binaries (.dylib, .jnilib, .so) from JARs that already contain Windows .dll natives via process-native-libs.sh to slim the bundle; no codesigning step (no Authenticode cert configured). - Generate a multi-resolution .ico from the shared icon.png using ImageMagick (magick or convert fallback) in create-ico.sh. - Tag the produced MSI with the target arch (INCEpTION-41.0-x86_64.msi) inside the script so multiple builds can coexist; idempotent on re-runs. - Configure the installer with --win-dir-chooser, --win-menu, and --win-shortcut for sensible Windows installer UX defaults. - Add dist-win profile to the parent reactor exposing the new module. - Add dist-win.yml GitHub Actions workflow (manual workflow_dispatch) that runs on windows-latest (WiX + ImageMagick preinstalled), verifies build prerequisites, runs the dist-win Maven build, and uploads the MSI as a workflow artifact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in the PR
How to test manually
Automatic testing
Documentation