fix(installer): extract Python core to user directory and update configs#706
Conversation
- Extract python_core.7z to APPDATA during installation - Clean up existing python_core before extraction - Update scheduler default config to conf.yaml - Bump version to 1.1.8
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Electron app version to 1.1.8, changes the scheduler's default configuration file to a YAML format, and adds a cleanup step for the Python core archive in the build script. Feedback indicates that the primary logic for Python core extraction described in the PR summary is missing from the code changes. Additionally, it is recommended to add error handling to the archive deletion command in the build script to ensure build failures are caught.
| { | ||
| "name": "astron-rpa", | ||
| "version": "1.1.6", | ||
| "version": "1.1.8", |
There was a problem hiding this comment.
The pull request title and description mention significant changes such as extracting the Python core to the user directory (APPDATA) and cleaning up the existing core before extraction. However, the current diff only includes a version bump, a default configuration path change, and a build script cleanup. The core logic for the extraction process (likely within the Electron main process or installer configuration) appears to be missing from this PR.
| REM ============================================ | ||
|
|
||
| echo Compressing python_core directory... | ||
| if exist "%SCRIPT_DIR%\%ARCHIVE_DIST_DIR%\python_core.7z" del /f /q "%SCRIPT_DIR%\%ARCHIVE_DIST_DIR%\python_core.7z" |
There was a problem hiding this comment.
This line correctly cleans up the previous build's archive. However, the PR description mentions 'Clean up existing python_core before extraction'. If this was intended to ensure a clean source directory before compression, you should consider removing the %PYTHON_CORE_DIR% directory earlier in the script (e.g., before line 176), as the current logic skips copying if python.exe already exists. Additionally, consider adding error handling to this command to ensure the build fails if the file cannot be deleted (e.g., due to being locked).
if exist "%SCRIPT_DIR%\%ARCHIVE_DIST_DIR%\python_core.7z" del /f /q "%SCRIPT_DIR%\%ARCHIVE_DIST_DIR%\python_core.7z" || exit /b 1
…igs (iflytek#706) - Extract python_core.7z to APPDATA during installation - Clean up existing python_core before extraction - Update scheduler default config to conf.yaml - Bump version to 1.1.8
…igs (#706) - Extract python_core.7z to APPDATA during installation - Clean up existing python_core before extraction - Update scheduler default config to conf.yaml - Bump version to 1.1.8
1 participant
📝 Pull Request 描述 | Description
🎯 变更类型 | Change Type
/cc @horizon220222