fix: prevent IDOR in admin read and password update endpoints - #1484
Open
adityaghate66-sketch wants to merge 2 commits into
Open
fix: prevent IDOR in admin read and password update endpoints#1484adityaghate66-sketch wants to merge 2 commits into
adityaghate66-sketch wants to merge 2 commits into
Conversation
- Added ownership verification in updatePassword to ensure only the authenticated user can update their own password - Added similar check in read endpoint to prevent unauthorized access to other admin profiles - Both endpoints previously accepted any admin ID without verifying ownership, allowing account takeover - Fix enforces that req.params.id must match the authenticated user's ID before allowing operations
adityaghate66-sketch
force-pushed
the
adityaMybranch
branch
from
July 31, 2026 13:10
6810677 to
463a451
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a brief description of the changes or additions made in this pull request.
Related Issues
If this pull request is related to any issue(s), please list them here.
Steps to Test
Provide steps on how to test the changes introduced in this pull request.
Screenshots (if applicable)
If your changes include visual updates, it would be helpful to provide screenshots of the before and after.
Checklist
PR-#1470