Skip to content

fix: Remove unnecessary clones #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanmonstar merged 1 commit into from
Jun 8, 2026
+3 −3
Merged

fix: Remove unnecessary clones #911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1334,7 +1334,7 @@ where
reset_stream_max: builder.reset_stream_max,
remote_reset_stream_max: builder.pending_accept_reset_stream_max,
local_error_reset_streams_max: builder.local_max_error_reset_streams,
settings: builder.settings.clone(),
settings: builder.settings,
},
);
let send_request = SendRequest {
Expand Down
4 changes: 2 additions & 2 deletions tests/h2-tests/tests/flow_control.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2410,7 +2410,7 @@ async fn capacity_not_assigned_to_unopened_streams() {

let (response1, mut stream1) = client.send_request(request.clone(), false).unwrap();
stream1.send_data("hello".into(), false).unwrap();
let (_, mut stream2) = client.send_request(request.clone(), false).unwrap();
let (_, mut stream2) = client.send_request(request, false).unwrap();
stream2.reserve_capacity(frame::DEFAULT_INITIAL_WINDOW_SIZE as usize);
stream1.send_data("world".into(), true).unwrap();
h2.drive(response1).await.unwrap();
Expand Down Expand Up @@ -2469,7 +2469,7 @@ async fn new_initial_window_size_capacity_not_assigned_to_unopened_streams() {

let (response1, mut stream1) = client.send_request(request.clone(), false).unwrap();
stream1.send_data("hello".into(), false).unwrap();
let (_, mut stream2) = client.send_request(request.clone(), false).unwrap();
let (_, mut stream2) = client.send_request(request, false).unwrap();
stream2.reserve_capacity(frame::DEFAULT_INITIAL_WINDOW_SIZE as usize);
h2.drive(response1).await.unwrap();
stream1.send_data("world".into(), true).unwrap();
Expand Down