fix: stable fingerprint for closures capturing non-deterministic state#8228
Open
kamaleshpanda wants to merge 2 commits into
Open
fix: stable fingerprint for closures capturing non-deterministic state#8228kamaleshpanda wants to merge 2 commits into
kamaleshpanda wants to merge 2 commits into
Conversation
When a map function is a closure capturing 'self', dill serializes the full object including non-deterministic state (UUIDs, loggers, object IDs). This causes a cache miss on every new class instantiation even when the actual computation is identical. Fix: hash only primitive values from captured objects instead of the full object, so unrelated internal state doesn't affect the fingerprint. Fixes huggingface#7986
Member
|
I feel like this would cause headaches to many people, causing cache reuses when the function actually changed |
Author
|
You're right, thank you for pointing that out. The current approach is too What approach would you suggest? Should we instead warn the user when a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7986
When
.map()uses a closure capturingselfwith non-deterministic state(like UUIDs or loggers), the fingerprint changes every run causing cache misses.
Fix: only hash primitive attributes of captured objects instead of the full object.
Added a regression test in
tests/test_fingerprint.py.