Use ha-switch instead of ha-control-switch in entity toggle#51852
Open
Use ha-switch instead of ha-control-switch in entity toggle#51852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Migrates
ha-entity-toggleandhui-entities-togglefromha-control-switchtoha-switch.Motivation:
ha-control-switchcannot currently be themedAlso adds a
--ha-switch-min-touch-sizeCSS variable toha-switch(defaults to 40px), mirroring the touch-target pattern already inha-control-switch. This keeps the recommended 40px hit area even when the switch is sized compact (38×20 in entity toggle).Screenshots
Entities card
Before

After

Group config flow
Before

After

Type of change
Additional information
In the future, we can consider changing the different UI component for entities card to better match tile card :
Design example proposal by dcapslock on discord :

Checklist
If user exposed functionality or configuration variables are added/changed:
To help with the load of incoming pull requests: