Resolve service name and icon for shortcut card and badge#51850
Merged
Resolve service name and icon for shortcut card and badge#51850
Conversation
wendevlin
reviewed
May 4, 2026
Member
wendevlin
left a comment
There was a problem hiding this comment.
I don't like that we create here a new class that uses the full hass object even it's not needed. I think it's just needed for serviceIcon so we also need to change getServiceIcons -> getCategoryIcons.
If you think it's too much for a beta change, we can approve as it is, but I would vote for defining the hass scope for the class.
Member
Author
|
Yeah, it's also used for localize and loadBackendTranslations. So the change will be too much for beta scope. |
Member
Mhh but this can be just passed from hass into the serviceController right? I don't see a big change in other places here. |
wendevlin
approved these changes
May 4, 2026
piitaya
added a commit
that referenced
this pull request
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
For shortcut cards and badges with a
perform-actiontap action, the displayed label and icon now reflect the chosen service instead of falling back to a generic bell icon and the raw service ID.For example,
frontend.reload_themesnow shows "Reload themes" with the service's icon (or a per-domain fallback while the icon resolves), rather thanfrontend.reload_themeswith the generic bell.Screenshots
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
To help with the load of incoming pull requests: