open state for cover removed from "active color"

[vojtechj]

Proposed change

Why on earth would someone consider open state of a cover as an active state?
If I have for example a garage door or a gate ... shouldn't the active state be only
when the gate/garage door are moving? i.e. opening/closing?

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Checklist

• I understand the code I am submitting and can explain how it works.
• The code change is tested and works locally.
• There is no commented out code in this PR.
• I have followed the perfect PR recommendations
• Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hi @vojtechj

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[karwosts]

That's not really the definition of "active", it just means like which state is most significant/highlighted.

E.g. we have tile card currently colored purple when a cover is open, and grey when it is closed. With this change it will be grey both when it is open and closed, which I don't think is desired. So I don't think this should be accepted.

Can you explain what problem you're trying to solve, what you want the end-result to be?

[vojtechj]

That's not really the definition of "active", it just means like which state is most significant/highlighted.

E.g. we have tile card currently colored purple when a cover is open, and grey when it is closed. With this change it will be grey both when it is open and closed, which I don't think is desired. So I don't think this should be accepted.

Can you explain what problem you're trying to solve, what you want the end-result to be?

In the source files it's called active, so I called it active as well.

Let's imagine an example: A gate with a beacon. When a gate is opening or closing, the beacon lights up (or blinks). When the gate stops moving (is closed or open) the beacon is off. And that's make a lot of sense to have the beacon light up when the gate is moving, doesn't it?
Now I want to control the gate via home assistant app. And I am not the only person controlling the gate that way. Would it make sense to have the button controlling the gate get highlighted (change color) when the gate is moving, just like the beacon?