Conversation
Member
Author
|
@pcan08 here's the PR. |
13 tasks
Contributor
|
It looks nice. IMO the dialog could be wider on desktop with 2 columns.
|
pcan08
reviewed
Apr 24, 2026
Comment on lines
+54
to
+65
| <label class="home-list-item summary-toggle"> | ||
| <ha-icon | ||
| .icon=${item.icon} | ||
| style=${styleMap({ "--mdc-icon-size": "24px", color })} | ||
| ></ha-icon> | ||
| <span class="label">${label}</span> | ||
| <ha-switch | ||
| .checked=${!hidden.has(item.key)} | ||
| .summary=${item.key} | ||
| @change=${this._toggleChanged} | ||
| ></ha-switch> | ||
| </label> |
Contributor
There was a problem hiding this comment.
I suggest
<ha-settings-row slim>
<ha-icon
slot="prefix"
.icon=${item.icon}
style=${styleMap({ "--mdc-icon-size": "24px", color })}
></ha-icon>
<span slot="heading">${label}</span>
<ha-switch
.checked=${!hidden.has(item.key)}
.summary=${item.key}
@change=${this._toggleChanged}
></ha-switch>
</ha-settings-row>
Comment on lines
+100
to
+110
| .summary-toggle { | ||
| display: flex; | ||
| align-items: center; | ||
| gap: var(--ha-space-3); | ||
| padding: var(--ha-space-2) 0; | ||
| cursor: pointer; | ||
| } | ||
| .summary-toggle .label { | ||
| flex: 1; | ||
| font-size: 14px; | ||
| } |
Contributor
There was a problem hiding this comment.
and replace with
ha-settings-row {
padding: var(--ha-space-2) 0;
gap: var(--ha-space-3);
--settings-row-prefix-display: contents;
}
timmo001
reviewed
Apr 24, 2026
Member
Author
|
@pcan08 I used the |
yubrah93
approved these changes
Apr 24, 2026
yubrah93
approved these changes
Apr 25, 2026
MindFreeze
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Consistency pass over the Home panel editor dialog from #51407:
common-controlssection strategy: removed theshow_predictedScreenshots
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
To help with the load of incoming pull requests: