Skip to content

Use header-subtitle in dialog-edit-home#51525

Merged
silamon merged 1 commit intohome-assistant:devfrom
pcan08:home-dashboard-use-header-subtitle-in-edit-dialog
Apr 12, 2026
Merged

Use header-subtitle in dialog-edit-home#51525
silamon merged 1 commit intohome-assistant:devfrom
pcan08:home-dashboard-use-header-subtitle-in-edit-dialog

Conversation

@pcan08
Copy link
Copy Markdown
Contributor

@pcan08 pcan08 commented Apr 12, 2026

Proposed change

Replace the custom <p class="description"> element and its associated CSS with the built-in headerSubtitle property on ha-dialog.

It simplifies the code, avoid specific CSS and reuse dialog capability that seems appropriate here. Moreover, it allows to gain space in the dialog.

This is related to #51401 (comment), so this PR should be considered as a step to improve the home dashboard settings dialog look and feel.

Screenshots

Before:
Capture d’écran du 2026-04-12 09-57-13

After:
Capture d’écran du 2026-04-12 09-59-37

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to backend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

To help with the load of incoming pull requests:

Replace the custom `<p class="description">` element and its associated
CSS with the built-in `headerSubtitle` property on `ha-dialog`.
@silamon silamon merged commit d025a84 into home-assistant:dev Apr 12, 2026
12 checks passed
MikeDev96 pushed a commit to MikeDev96/frontend that referenced this pull request Apr 15, 2026
Replace the custom `<p class="description">` element and its associated
CSS with the built-in `headerSubtitle` property on `ha-dialog`.
marcinbauer-ohf pushed a commit to marcinbauer-ohf/frontend that referenced this pull request Apr 16, 2026
Replace the custom `<p class="description">` element and its associated
CSS with the built-in `headerSubtitle` property on `ha-dialog`.
@pcan08 pcan08 deleted the home-dashboard-use-header-subtitle-in-edit-dialog branch April 25, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants