fix(studio): prevent SourceEditor recreation on every keystroke#786
Closed
Jefsky wants to merge 1 commit into
Closed
fix(studio): prevent SourceEditor recreation on every keystroke#786Jefsky wants to merge 1 commit into
Jefsky wants to merge 1 commit into
Conversation
Collaborator
|
Closing in favor of #624 which has the same fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
SourceEditorcomponent was destroying and recreating the CodeMirrorEditorViewon every keystroke, becausemountEditorwas used as both a callback ref and auseCallbackwithcontentin its dependency array.What changed
contentfrom themountEditordependency arraycontentRefto pass initial content without subscribing to changesuseEffectthat syncs external content changes (file switches, server refreshes) into the existing editor viadispatch()without recreating itResult: cursor position, undo history, and focus are preserved across keystrokes.
Closes #624