Skip to content

fix(studio): keep preview selection overlay visible for selected item #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguel-heygen merged 1 commit into from
May 13, 2026
+1 −15
Merged

fix(studio): keep preview selection overlay visible for selected item #777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions packages/studio/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import {
STUDIO_MOTION_PANEL_ENABLED,
} from "./components/editor/manualEditingAvailability";
import { getStudioMotionForSelection } from "./components/editor/studioMotion";
import { getTimelineElementKey, isTimelineElementActiveAtTime } from "./utils/timelineInspector";
import type { DomEditSelection } from "./components/editor/domEditing";
import { AskAgentModal } from "./components/AskAgentModal";
import { StudioHeader } from "./components/StudioHeader";
Expand Down Expand Up @@ -79,7 +78,6 @@ export function StudioApp() {
const captionSync = useCaptionSync(projectId);
const currentTime = usePlayerStore((s) => s.currentTime);
const timelineElements = usePlayerStore((s) => s.elements);
const selectedTimelineElementId = usePlayerStore((s) => s.selectedElementId);
const setSelectedTimelineElementId = usePlayerStore((s) => s.setSelectedElementId);
const timelineDuration = usePlayerStore((s) => s.duration);
const isPlaying = usePlayerStore((s) => s.isPlaying);
Expand Down Expand Up @@ -284,14 +282,6 @@ export function StudioApp() {
domEditSession.domEditSelection,
)
: null;
const selectedTimelineElement = useMemo(
() =>
selectedTimelineElementId
? (timelineElements.find((el) => getTimelineElementKey(el) === selectedTimelineElementId) ??
null)
: null,
[selectedTimelineElementId, timelineElements],
);
const designPanelActive =
STUDIO_INSPECTOR_PANELS_ENABLED && panelLayout.rightPanelTab === "design";
const motionPanelActive =
Expand All @@ -300,11 +290,7 @@ export function StudioApp() {
panelLayout.rightPanelTab === "motion";
const inspectorPanelActive = designPanelActive || motionPanelActive;
const shouldShowSelectedDomBounds =
inspectorPanelActive &&
!panelLayout.rightCollapsed &&
!isPlaying &&
(!selectedTimelineElement ||
isTimelineElementActiveAtTime(currentTime, selectedTimelineElement));
inspectorPanelActive && !panelLayout.rightCollapsed && !isPlaying;
const inspectorButtonActive =
STUDIO_INSPECTOR_PANELS_ENABLED && !panelLayout.rightCollapsed && inspectorPanelActive;

Expand Down
Loading