fix(render): retry transient network changes#2294
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Classify Chromium
net::ERR_NETWORK_CHANGEDnavigation failures as transient capture errors.Why
A Windows render failed mid-capture while navigating the local HyperFrames server with
net::ERR_NETWORK_CHANGED; an immediate retry succeeded. The bounded browser retry classifier did not recognize this Chromium network-stack transition, so otherwise recoverable captures could fail on the first occurrence.How
Add the error signature to the existing transient-browser classifier, which routes it through the already bounded fresh-session retry path. Add a regression case with the localhost URL form reported by Chromium.
Test plan
bunx vitest run src/services/frameCapture-transientErrors.test.ts(42 passed)bun run typecheckbunx oxfmt --check src/services/frameCapture.ts src/services/frameCapture-transientErrors.test.tsbunx oxlint src/services/frameCapture.ts src/services/frameCapture-transientErrors.test.ts-fps_mode.