refactor: migrate to shared eslint config

.github/workflows/ci.yml

@@ -22,6 +22,8 @@ jobs:
           node-version: 22.x
           cache: npm
       - run: npm ci
+      - name: build
+        run: npm run build
       - name: linting
         run: npm run lint
 

.github/workflows/promote.yml

@@ -65,4 +65,4 @@ jobs:
             --channel=${{ fromJSON(inputs.isStableRelease) && 'stable' || env.prerelease-channel }}
         shell: bash
       - name: promote Linux install scripts
-        run: node ./scripts/postrelease/install_scripts.js
+        run: node ./scripts/postrelease/install-scripts.js

bin/bats-test-runner.js

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 
-import os from 'os'
-import { spawn } from 'child_process'
+import {spawn} from 'node:child_process'
+import os from 'node:os'
 
 if (os.platform() === 'win32' || os.platform() === 'windows') console.log('skipping on windows')
-else spawn('npx bats test/acceptance/*.bats', {stdio: 'inherit', shell: true})
+else spawn('npx bats test/acceptance/*.bats', {shell: true, stdio: 'inherit'})

bin/run.js

@@ -12,7 +12,7 @@ process.env.HEROKU_UPDATE_INSTRUCTIONS = process.env.HEROKU_UPDATE_INSTRUCTIONS
 const now = new Date()
 const cliStartTime = now.getTime()
 
-const {isTelemetryEnabled, getTelemetryDisabledReason, telemetryDebug} = await import('../dist/lib/analytics-telemetry/telemetry-utils.js')
+const {getTelemetryDisabledReason, isTelemetryEnabled, telemetryDebug} = await import('../dist/lib/analytics-telemetry/telemetry-utils.js')
 const enableTelemetry = isTelemetryEnabled()
 
 if (enableTelemetry) {

eslint.config.js

@@ -0,0 +1,39 @@
+// ESLint 9 flat config using shared Heroku CLI rules
+import herokuConfig from '@heroku-cli/test-utils/eslint-config'
+
+export default [
+  ...herokuConfig,
+  // Project-specific overrides
+  {
+    rules: {
+      '@typescript-eslint/no-unused-vars': 'warn',
+      'array-callback-return': 'warn',
+      camelcase: 'off',
+      'n/no-unpublished-bin': 'off', // we're getting false positives with this
+      'n/no-unsupported-features/node-builtins': 'warn',
+      'no-await-in-loop': 'warn',
+      'no-promise-executor-return': 'warn',
+      semi: ['warn', 'never'],
+      'unicorn/consistent-function-scoping': 'warn',
+      'unicorn/no-array-callback-reference': 'warn',
+      'unicorn/no-array-for-each': 'warn',
+      'unicorn/no-array-reduce': 'warn',
+      'unicorn/no-empty-file': 'warn',
+      'unicorn/prefer-event-target': 'warn',
+      'unicorn/prefer-spread': 'warn',
+    },
+  },
+  // Test file overrides
+  {
+    files: ['test/**/*.ts', 'test/**/*.js'],
+    rules: {
+      'mocha/max-top-level-suites': 'warn',
+      'mocha/no-exports': 'warn',
+      'unicorn/consistent-function-scoping': 'warn',
+    },
+  },
+  // Ignore patterns (in addition to shared ignores)
+  {
+    ignores: ['**/test/**/*.js', '**/*.d.ts', '.github/**'],
+  },
+]