Make sure -W argument to compgen is escaped#28
Open
ncfavier wants to merge 1 commit intohedning:masterfrom
Open
Make sure -W argument to compgen is escaped#28ncfavier wants to merge 1 commit intohedning:masterfrom
-W argument to compgen is escaped#28ncfavier wants to merge 1 commit intohedning:masterfrom
Conversation
Shell quoting is honored in the argument to `-W`, which we approximate by not removing the double quotes from the Nix output. A more robust solution would be to use `nix-instantiate --json` and parse the output with `jq -r '@sh'`, but that requires adding an external dependency.
ncfavier
commented
Jan 31, 2024
Comment on lines
-1289
to
+1292
| COMPREPLY=($(compgen -W "${systems[*]//@(\[|\])/}" -- "$cur")) | ||
| COMPREPLY=($(compgen -W "${systems[*]}" -- "$cur")) |
Author
There was a problem hiding this comment.
_nix_eval_stdin already removes brackets.
13 tasks
13 tasks
github-merge-queue Bot
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Oct 17, 2025
Apply hedning/nix-bash-completions#26 to nixpkgs, since upstream seems dead. (PR has been sitting there for 2 years.) Due to a conflict with hedning/nix-bash-completions#28, which is already applied here in nixpkgs, pull 26 cannot be applied as is. I rebased it and added it locally to nixpkgs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NixOS/nixpkgs#284162
Shell quoting is honored in the argument to
compgen -W, which we approximate by not removing the double quotes from the Nix output.A more robust solution would be to use
nix-instantiate --jsonand parse the output withjq -r '@sh', but that requires adding an external dependency.