Fix/new category crash 10772#10794
Open
Learnobug wants to merge 1 commit intohcengineering:developfrom
Open
Conversation
|
Connected to Huly®: UBERF-16342 |
…ing hcengineering#10772 Signed-off-by: Learnobug <gunjanaggarwal12345@gmail.com>
Learnobug
force-pushed
the
fix/new-category-crash-10772
branch
from
db9d502 to
cc1fa62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
CreateDocumentCategory defaulted space to documents.space.QualityDocuments. On workspaces where the QMS space wasn't initialized (a data state possible after certain upgrades / non-QMS workspaces), the space reference was invalid:
NewDocumentHeader.svelte:60 called showPopup(CreateDocumentCategory, {}) with empty props, always relying on the default.
Categories.svelte:42 did the same even though it already had a valid space in scope.
createDoc() then submitted a transaction against a non-existent space → failed TxUpdateDoc transactions → UI crash.
Fix
Categories.svelte — pass the in-scope space to CreateDocumentCategory instead of relying on the default.
CreateDocumentCategory.svelte — verify the target DocumentSpace exists in onMount. If missing, disable the Save button (canSave = false) and log a clear error, preventing the crashing transaction. Also scope the existing-category/code lookup with { space } so duplicate-checks are correct per space.