Also check if the total hash count of a hashlist needs to be fixed#2033
Open
Also check if the total hash count of a hashlist needs to be fixed#2033
Conversation
jessevz
approved these changes
Apr 11, 2026
Contributor
|
We could reduce the amount of database queries here by instead of doing Factory::getHashlistFactory()->set(....) when a count doesnt match, is by adding the field that needs to be updated to an array, and then afterwards do mset if the array is not empty, then both hashcount and cracked can be updated in a single query. But this is a very minor performance improvement so I approved this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far only the cracked hashes counts where check, but not the total hash counts of the hashlist.