[Snyk] Security upgrade next from 14.2.32 to 15.5.10#395
[Snyk] Security upgrade next from 14.2.32 to 15.5.10#395hashim21223445 wants to merge 1 commit intomainfrom
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NEXT-15104645
Summary of ChangesHello @hashim21223445, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, implements a crucial security upgrade for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Make sure a JIRA issue is mentioned in the titleWaiting for:
This rule is failing.Make sure PR title contains a JIRA issue
🔴 Make sure a JIRA issue is mentioned in the titleWaiting for:
This rule is failing.Make sure PR title contains a JIRA issue
🔴 Enforce conventional commitWaiting for:
This rule is failing.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🔴 Force ticket associationWaiting for:
This rule is failing.Make sure PR has a ticket associated
🟠 Merge during working hoursWaiting for:
Waiting for schedule condition.Make sure to merge only during working hours
|
There was a problem hiding this comment.
Code Review
This pull request upgrades the next package from 14.2.32 to 15.5.10 to fix a security vulnerability. While this is a necessary security update, it's a major version bump that introduces breaking changes. The most critical issue is that Next.js 15 requires React 18, but the project is still on React 17. This incompatibility will likely break the application. I've added a comment with details on how to resolve this.
| "dependencies": { | ||
| "@types/react": "^17.0.21", | ||
| "next": "14.2.32", | ||
| "next": "15.5.10", |
There was a problem hiding this comment.
Upgrading next to a new major version (15.x) introduces breaking changes. Next.js versions 14 and later require React 18.2.0 or newer. This project is currently using React 17.0.2, which is incompatible and will likely cause the application to break.
To resolve this, you should also upgrade react, react-dom, and their corresponding types in your package.json:
"dependencies": {
"@types/react": "^18.0.0",
"next": "15.5.10",
"react": "^18.2.0",
"react-dom": "^18.2.0",
...
},After updating these dependencies, you may need to address other breaking changes introduced in React 18, such as changes to the root API.
⛔ Snyk checks have failed. 1 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
Custom Error Page/Error Page/package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-NEXT-15104645
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling