Skip to content

fix: bump vite to 8.0.10 (CVE-2026-39364) - #1532

Merged
AvivAbachi merged 2 commits into
mainfrom
fix/bump-vite-cve-2026-39364
May 6, 2026
Merged

fix: bump vite to 8.0.10 (CVE-2026-39364)#1532
AvivAbachi merged 2 commits into
mainfrom
fix/bump-vite-cve-2026-39364

Conversation

@eran132

@eran132 eran132 commented Apr 25, 2026

Copy link
Copy Markdown
Collaborator

Bumps vite from 8.0.x to 8.0.10 to fix CVE-2026-39364server.fs.deny
can be bypassed using query parameters like ?raw or ?import&raw,
allowing the dev server to expose files that should be denied.

Dev-server only — no production runtime impact. The Storybook peer
dependency warning is harmless (Storybook hasn't updated its peer range yet).

Closes Dependabot alert #150

Test plan

  • tsc --noEmit
  • npm run lint
  • npm run test:unit (9/9)
  • npx vite build (built in 31s)
  • Dev server runs (npx vite --port 5173) and dashboard loads
image

Copilot AI review requested due to automatic review settings April 25, 2026 17:56
@eran132
eran132 requested a review from AvivAbachi as a code owner April 25, 2026 17:56
@github-actions

github-actions Bot commented Apr 25, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps Vite from 8.0.x to 8.0.10 to address CVE-2026-39364 (dev server server.fs.deny bypass via ?raw / ?import&raw query params), updating the lockfile accordingly.

Changes:

  • Update vite devDependency to ^8.0.10.
  • Refresh package-lock.json to capture transitive dependency updates pulled in by the Vite bump.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
package.json Bumps Vite devDependency to ^8.0.10.
package-lock.json Updates the resolved Vite version and related transitive packages/metadata.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
"ts-jest": "^29.4.6",
"typescript": "^5.9.3",
"vite": "^8.0.0",
"vite": "^8.0.10",

Copilot AI Apr 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After bumping to Vite 8.0.10, Vite’s engines.node requires ^20.19.0 || >=22.12.0 (see package-lock.json). Our package.json currently allows Node >=22.0.0, which includes 22.0–22.11 that Vite will refuse to run on. Consider tightening engines.node (e.g. to >=22.12.0, or to match Vite’s range) to avoid install/runtime failures for developers on early Node 22 minors.

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @copilot. I changed engines.node to >=22.12.0 to match vite's requirement."

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The engines.node constraint has been tightened to >=22.12.0 in commit a5917be, matching Vite 8.0.10's requirement.

@AvivAbachi
AvivAbachi merged commit 79c8ecc into main May 6, 2026
26 checks passed
@AvivAbachi
AvivAbachi deleted the fix/bump-vite-cve-2026-39364 branch May 6, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants