fix: show success message on bug report submission

[eran132]

Summary

The bug report form showed an error message even when the GitHub issue was created successfully. The onSuccess handler checked response.data?.state === 'open' which didn't match the actual API response structure.

• Removed the strict state === 'open' check — form now resets on any successful API call
• Show success alert even when the issue URL isn't available in the response (fallback message)
• Users will no longer see a false error and submit duplicate reports

Closes #1431

Test plan

• TypeScript compiles clean
• ESLint + Prettier pass
• Unit tests pass (9/9)
• Existing Playwright tests cover success submission (mocked API returns 200 → success alert visible)
• Existing Playwright tests cover error submission (mocked API returns 500 → error alert visible)
• Existing Playwright tests cover missing field validation

Note: tests/bugReport.spec.ts already has E2E tests for both success (bug submission success) and error (bug submission server error) use cases with mocked backend endpoints.

🤖 Generated with Claude Code

[github-actions]

Preview: https://s3.amazonaws.com/noam-gaash.co.il/24455248755/open-bus/1803/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/24455248755/open-bus/1803/storybook/index.html
Test Report (if available): 'https://s3.amazonaws.com/noam-gaash.co.il/24455248755/open-bus/ddb012ec2405d273490320e8ec39a56ad9c4cca3/test-results/index.html'

[Copilot]

Pull request overview

Fixes the bug report form UX by ensuring a success state is shown after a successful GitHub issue creation request, without relying on an incorrect response.data.state === 'open' check.

Changes:

• Reset the AntD form on any successful mutation (removed state === 'open' gate).
• Always show a success Alert on mutation.isSuccess, with a fallback message when the issue URL is missing.
• Keep the “view issue” link behavior when a URL is available.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The link label uses "Github"; the correct brand capitalization is "GitHub" (and other strings in the repo use "GitHub"). Please update the text to avoid inconsistent UI copy.

Suggested change

	{t('reportBug.viewIssue')} (Github)
	{t('reportBug.viewIssue')} (GitHub)

[Copilot]

t('reportBug.success', { defaultValue: ... }) hardcodes an English fallback even though reportBug.success is already defined in the locale JSON files. Consider using t('reportBug.success') to keep the message fully controlled by translations (and avoid accidental English text in non-English locales if the key changes).

Suggested change

	t('reportBug.success', { defaultValue: 'Bug report submitted successfully!' })
	t('reportBug.success')

[NoamGaash]

Hi Eran! Thank you for your contribution.
I didn't have a time to review it manually yet, here's what Claude has to say:

The fix is correct. The original code had response.data?.state === 'open' which apparently never matched the actual API response shape, so the form never reset and no success message appeared.

One minor issue: the fallback string uses t('reportBug.success', { defaultValue: 'Bug report submitted successfully!' }) — the key reportBug.success doesn't exist in any translation file yet, so all languages will show the hardcoded English fallback. Fine as a quick fix, but worth a follow-up to add the translation key.

I hope I'll have the time to review it myself this weekend. Meanwhile, please make sure that your code is well-written and tested.
And again - thank you!
Noam

[NoamGaash]

You have mentioned a "Test plan" in your PR description and it seems like you didn't finish testing - please complete your PR and ask for a review once you feel it's ready.
Personally, I'd love to see a Playwright tests here that mocks the backend endpoint and cover both successful form submission and error use case. We can even make a visual test out of it.
Thanks!

[eran132]

Great idea @NoamGaash — I'll add Playwright tests that mock the backend endpoint and cover both successful form submission and error cases. Will update this PR.

[eran132]

Re-submitting from upstream branch (not fork) so previews and visual tests can run.