Open
Conversation
|
brandboat
force-pushed
the
HARV-7218
branch
2 times, most recently
from
645bd99 to
ed2b3e4
Compare
github-actions
Bot
requested review from
akashraj4261,
dariavladykina and
jillian-maroket
brandboat
requested review from
Vicente-Cheng,
WebberHuang1118,
rrajendran17,
starbops and
w13915984028
Contributor
There was a problem hiding this comment.
Pull request overview
Adds documentation for configuring Longhorn RWX volume traffic via the new rwx-network setting, and updates existing storage/RWX guidance to reference it.
Changes:
- Update RWX volumes prerequisites in the Rancher CSI driver docs to reference the
rwx-networksetting and IP exclusion guidance. - Expand storage network IP sizing guidance to account for RWX network sharing behavior.
- Document the new
rwx-networksetting insettings.mdand add a new dedicated “RWX Network” page with UI/CLI steps and verification.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| docs/rancher/csi-driver.md | Updates RWX volumes prerequisites and networking wording to reference rwx-network. |
| docs/advanced/storagenetwork.md | Adds IP sizing guidance and best-practices notes for RWX sharing on the storage network. |
| docs/advanced/settings.md | Documents the rwx-network setting, defaults, and examples. |
| docs/advanced/rwxnetwork.md | New page describing rwx-network modes, configuration steps, and validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
w13915984028
previously approved these changes
Mar 23, 2026
Member
w13915984028
left a comment
w13915984028
left a comment
There was a problem hiding this comment.
LGTM, thanks for the detailed document.
akashraj4261
previously approved these changes
Apr 13, 2026
WebberHuang1118
previously approved these changes
Apr 14, 2026
Member
WebberHuang1118
left a comment
WebberHuang1118
left a comment
There was a problem hiding this comment.
LGTM, just a nit, thanks.
Comment on lines
+58
to
+68
| - The Whereabouts CNI is installed correctly. | ||
|
|
||
| You can check if the `ippools.whereabouts.cni.cncf.io` CRD exists in the cluster using the command `kubectl get crd ippools.whereabouts.cni.cncf.io`. | ||
|
|
||
| If an empty string is returned, add the CRDs in [this directory](https://github.com/harvester/harvester/tree/v1.1.0/deploy/charts/harvester/dependency_charts/whereabouts/crds) using the following commands: | ||
|
|
||
| ``` | ||
| kubectl apply -f https://raw.githubusercontent.com/harvester/harvester/v1.1.0/deploy/charts/harvester/dependency_charts/whereabouts/crds/whereabouts.cni.cncf.io_ippools.yaml | ||
|
|
||
| kubectl apply -f https://raw.githubusercontent.com/harvester/harvester/v1.1.0/deploy/charts/harvester/dependency_charts/whereabouts/crds/whereabouts.cni.cncf.io_overlappingrangeipreservations.yaml | ||
| ``` |
Member
There was a problem hiding this comment.
Do we need to mention this part specifically? Whereabouts should already be deployed.
Member
Author
There was a problem hiding this comment.
Removed in the latest commit, do u want to take another look?
Signed-off-by: Cooper Tseng <cooper.tseng@suse.com>
brandboat
dismissed stale reviews from WebberHuang1118, akashraj4261, and w13915984028
via
f167b91
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs for harvester/harvester#7218 and harvester/harvester#6910