feat: parenthesized sub expressions with engine aware tokenization #879
Draft
jg-rp wants to merge 1 commit intoharttle:masterfrom
Draft
feat: parenthesized sub expressions with engine aware tokenization #879jg-rp wants to merge 1 commit intoharttle:masterfrom
jg-rp wants to merge 1 commit intoharttle:masterfrom
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an alternative implementation of parenthesized sub expressions, as described in #833 and #863.
In an attempt to throw "undefined filter" errors at parse-time rather than render-time, we've changed the
Tokenizerconstructor to require aLiquidargument, allowing us to look up filter implementations during tokenization.A new
PropTokentype is defined for the benefit ofPropertyAccessToken, and we've addedTokenizer.readPropertyas an alternative toreadValue()that explicitly excludesreadGroupOrRange().Please treat this PR as a proof of concept. It is far from ideal. I have copied some tests from #863 without forking and giving credit to @skynetigor.