Fix decoding response data - #286
Open
sugyan wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for this fix! The decoding improvement is valuable, especially for non-ASCII characters. However, this PR has merge conflicts with recent updates. Would you be able to rebase this PR against the current master branch? The fix is still relevant and would be great to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When searching in Japanese, there was a problem that garbled characters were generated in metadata obtained by
extract_meta.In
download_pageit usesstr(resp.read())to convert bytes to a string, which is wrong, It must decode correctly.And it can eliminate unnecessary conversion when converting to JSON.
I also added test cases.