Conversation
e695b8e to
35d2411
Compare
|
Thanks for the PR. I'm not exactly sure what it's fixing, maybe it would be worth adding a quick test (in test/index.ts) to ensure there's no regression in the future? |
|
@Marsup this PR fixes this issue with the types around The 2nd arg of Also, |
|
I added the test. It fixes what @davidjamesstone mentioned, so it closes #3064 |
8673c3e to
7a79df0
Compare
|
I'm not yet sure what's the problem with the tests, the error line doesn't match, I'm investigating. |
|
OK, it's because of your render function calls, I'm honestly not sure it should be exposed, as the state is kind of hard to recreate from outside of joi. |
7a79df0 to
d782e4f
Compare
|
What shouldn't be exposed ? |

Joi.expressiondid not acceptfunctionsrecord, and returnedany.