fix(google-cloud-spanner): address compatibility issues with spanner experimental#16593
Open
sagnghos wants to merge 1 commit intogoogleapis:mainfrom
Open
fix(google-cloud-spanner): address compatibility issues with spanner experimental#16593sagnghos wants to merge 1 commit intogoogleapis:mainfrom
sagnghos wants to merge 1 commit intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces disable_builtin_metrics and _experimental_host to the Spanner clients and updates test configurations. Reviewers identified several issues: _experimental_host is used without being initialized in the constructor, potentially causing an AttributeError, and disable_builtin_metrics is defined within a conditional block, which could lead to an UnboundLocalError. Additionally, the project argument was removed from the AsyncClient instantiation in tests, which is necessary for correct initialization.
parthea
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility with experimental host broke post the major refactor in https://github.com/googleapis/python-spanner/pull/1509/changes.
These minor changes fixed the compatibility. Verified with below integration tests run
Integration test successful: