Skip to content

fix: update the docstring in table_type property#16590

Open
roykoand wants to merge 1 commit intogoogleapis:mainfrom
roykoand:main
Open

fix: update the docstring in table_type property#16590
roykoand wants to merge 1 commit intogoogleapis:mainfrom
roykoand:main

Conversation

@roykoand
Copy link
Copy Markdown

@roykoand roykoand commented Apr 9, 2026

No description provided.

@roykoand roykoand requested review from a team as code owners April 9, 2026 07:53
@roykoand roykoand requested a review from sycai April 9, 2026 07:53
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates docstrings in google/cloud/bigquery/table.py to include 'SNAPSHOT' and 'MATERIALIZED_VIEW' as valid table types. The review feedback indicates that the list of possible table types is still incomplete, specifically missing 'CLONE', and suggests adding an Oxford comma for improved clarity and consistency in the docstrings.

Comment on lines +737 to +738
Possible values are ``'TABLE'``, ``'VIEW'``, ``'MATERIALIZED_VIEW'``,
``'SNAPSHOT'`` or ``'EXTERNAL'``.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The list of possible table types is incomplete. According to the BigQuery API documentation, 'CLONE' is also a valid value for the table type. Additionally, using an Oxford comma (a comma before the 'or') is generally preferred for clarity in lists of three or more items and improves consistency across the library.

Suggested change
Possible values are ``'TABLE'``, ``'VIEW'``, ``'MATERIALIZED_VIEW'``,
``'SNAPSHOT'`` or ``'EXTERNAL'``.
Possible values are 'TABLE', 'VIEW', 'MATERIALIZED_VIEW',
'SNAPSHOT', 'CLONE', or 'EXTERNAL'.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what BigQuery API documentation AI reviewer references, but when I run the following snippet for the CLONE type table I get the TABLE type:

>> table = client.get_table("dataset.clone")
>> table.table_type
'TABLE'

while in the INFORMATION_SCHEMA.TABLES it says CLONE in table_type column

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant