Fix EntityManager leak in ThreadLocal after failed transaction#1917
Open
SantanuKar43 wants to merge 2 commits intogoogle:masterfrom
Open
Fix EntityManager leak in ThreadLocal after failed transaction#1917SantanuKar43 wants to merge 2 commits intogoogle:masterfrom
SantanuKar43 wants to merge 2 commits intogoogle:masterfrom
Conversation
Author
|
@sameb @lukesandberg can you please review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in JpaLocalTxnInterceptor where a broken EntityManager could remain in a thread’s ThreadLocal after a failed transaction, leading to subsequent requests failing when the same thread is reused by the web server (e.g., Jetty).
Problem
Fix
Related Issue
Fixes #1916 and #1179