Add annotation to allow passthrough default methods on assisted factories#1760
Open
jpenilla wants to merge 1 commit intogoogle:masterfrom
Open
Add annotation to allow passthrough default methods on assisted factories#1760jpenilla wants to merge 1 commit intogoogle:masterfrom
jpenilla wants to merge 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jpenilla
force-pushed
the
feat/passthrough-default-methods
branch
from
41695cb to
6b69db1
Compare
…thods on assisted factories (but only when explicitly requested by the user, see google#1347 (comment))
jpenilla
force-pushed
the
feat/passthrough-default-methods
branch
from
6b69db1 to
1373b06
Compare
Contributor
|
Any chance you could take a look at this, @sameb? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1345
Add
@PassthroughDefaultMethodsannotation to allow using default methods on assisted factories (but only when explicitly requested by the user, see #1347 (comment))As mentioned in the linked comment, we don't want to change existing behavior in case anyone is relying on it. So instead we add an annotation to specify what behavior we want. If the annotation was only able to be placed on individual methods, a more generic name like
@Unassistedmight be ok, however since I am also allowing the annotation on factory interfaces, I felt a more specific name made sense.