Skip to content

Make class Message unhashable #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ttanay wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make class Message unhashable #262

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87f96a6
Add __hash__ to class Message to make it hashable in Python 3
ttanay Mar 3, 2019
0ace821
Make __hash__ implementation consistent with __eq__
ttanay Mar 11, 2019
ea930a3
Make __hash__ None for class Message
ttanay Mar 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apitools/base/protorpclite/messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,6 +758,8 @@ class Order(Message):

"""

__hash__ = object.__hash__

@tvalentyn tvalentyn Mar 11, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think hash should be consistent with implementation of __eq__, so that equal messages have equal hashes.


def __init__(self, **kwargs):
"""Initialize internal messages state.

Expand Down