fix: fix Claude MCP tool inputSchema by falling back to parametersJsonSchema#1342
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_945069237
branch
2 times, most recently
from
eb19d47 to
2f21543
Compare
…JsonSchema` `Claude.functionDeclarationToAnthropicTool()` only read `FunctionDeclaration.parameters()` and ignored `parametersJsonSchema()`. MCP tools populate `parametersJsonSchema` instead of `parameters`, so their input schema was converted into an empty `properties` map and Claude received tools with no arguments, making them impossible to invoke. When `parametersJsonSchema` is present, pass the whole JSON Schema through so keys such as `$ref`/`$defs` are preserved, and recursively lowercase `type` keywords for Anthropic. `updateTypeString` now also handles union `type` arrays instead of failing on the `String` cast. This mirrors the Python `anthropic_llm.py` implementation. PiperOrigin-RevId: 945624831
copybara-service
Bot
force-pushed
the
test_945069237
branch
from
2f21543 to
760c8da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: fix Claude MCP tool
inputSchemaby falling back toparametersJsonSchemaClaude.functionDeclarationToAnthropicTool()only readFunctionDeclaration.parameters()and ignoredparametersJsonSchema(). MCPtools populate
parametersJsonSchemainstead ofparameters, so their inputschema was converted into an empty
propertiesmap and Claude received toolswith no arguments, making them impossible to invoke.
When
parametersJsonSchemais present, pass the whole JSON Schema through sokeys such as
$ref/$defsare preserved, and recursively lowercasetypekeywords for Anthropic.
updateTypeStringnow also handles uniontypearraysinstead of failing on the
Stringcast. This mirrors the Pythonanthropic_llm.pyimplementation.