Summary
Gitea's /api/v1/teams/{id} API routes do not correctly enforce the public-only access token restriction.
A public-only token is intended to limit API access to public repositories and public organizations. However, several team API routes continue to return private team repository metadata and private team activity feed entries when called with a public-only token.
Details
The /api/v1/teams/{teamid} route group uses:
orgAssignment(false, true)
This loads ctx.Org.Team, but does not load ctx.Org.Organization.
The checkTokenPublicOnly middleware checks organization visibility through ctx.Org.Organization. When ctx.Org.Organization is nil, the organization visibility check silently passes.
In addition, the team repository handlers return repositories without applying repository-level public-only filtering:
repo_model.GetTeamRepositories(...)
convert.ToRepo(...)
They do not call:
ctx.TokenCanAccessRepo(repo)
The team activity feed handler also sets:
but does not apply:
opts.ApplyPublicOnly(ctx.PublicOnly)
PoC
Vulnerability is verified on latest gitea release (1.26.2) and nightly build.
Frist, create a public-only organization-scoped token for a user who is a member of a team in a private org with private repositories:
Use the returned token to request team repositories:
Expected result: Private repositories should be hidden or rejected for a public-only token.
Actual result: Private team repository metadata is returned.
The team activity feed endpoint can be tested similarly:
Impact
A public-only token can access private team resources that should be hidden from that token.
Summary
Gitea's
/api/v1/teams/{id}API routes do not correctly enforce thepublic-onlyaccess token restriction.A
public-onlytoken is intended to limit API access to public repositories and public organizations. However, several team API routes continue to return private team repository metadata and private team activity feed entries when called with apublic-onlytoken.Details
The
/api/v1/teams/{teamid}route group uses:This loads
ctx.Org.Team, but does not loadctx.Org.Organization.The
checkTokenPublicOnlymiddleware checks organization visibility throughctx.Org.Organization. Whenctx.Org.Organizationis nil, the organization visibility check silently passes.In addition, the team repository handlers return repositories without applying repository-level
public-onlyfiltering:They do not call:
The team activity feed handler also sets:
IncludePrivate: truebut does not apply:
PoC
Vulnerability is verified on latest gitea release (1.26.2) and nightly build.
Frist, create a
public-onlyorganization-scoped token for a user who is a member of a team in a private org with private repositories:Use the returned token to request team repositories:
Expected result: Private repositories should be hidden or rejected for a public-only token.
Actual result: Private team repository metadata is returned.
The team activity feed endpoint can be tested similarly:
Impact
A
public-onlytoken can access private team resources that should be hidden from that token.