Skip to content

chore: bump declaration-strict-value and reconfigure it - #39080

Merged
bircni merged 3 commits into
go-gitea:mainfrom
silverwind:stylelint-ignore-at-rules
Aug 24, 2026
Merged

chore: bump declaration-strict-value and reconfigure it#39080
bircni merged 3 commits into
go-gitea:mainfrom
silverwind:stylelint-ignore-at-rules

Conversation

@silverwind

@silverwind silverwind commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Bump https://github.com/AndyOGo/stylelint-declaration-strict-value and configure it to avoid needing these lint exclusions.

Related: AndyOGo/stylelint-declaration-strict-value#201

@silverwind
chore: skip declaration-strict-value inside @font-face and @page
17f7a6a 
Neither at-rule is an element context, so var() has nothing to resolve
against and enforcing a variable there is a footgun. This drops the
per-line disables on every @font-face font-weight descriptor.

Needs stylelint-declaration-strict-value 1.12.0 for ignoreAtRules.

Assisted-by: Claude Code:claude-opus-5
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 24, 2026
@silverwind silverwind changed the title chore: skip declaration-strict-value inside @font-face and @page chore: bumo declaration-strict-value and reconfigure it Aug 24, 2026
@silverwind silverwind changed the title chore: bumo declaration-strict-value and reconfigure it chore: bump declaration-strict-value and reconfigure it Aug 24, 2026
@github-actions github-actions Bot added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/code-linting labels Aug 24, 2026
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 24, 2026
@silverwind
chore: use ignoreAtRules array form
2a3e713 
1.12.1 fixes the missing array check, so the at-rules can be listed
directly instead of via the property hash.

Assisted-by: Claude Code:claude-opus-5
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 24, 2026
@bircni bircni added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 24, 2026
@bircni
bircni enabled auto-merge (squash) August 24, 2026 20:01
@bircni
bircni merged commit 0b10674 into go-gitea:main Aug 24, 2026
23 checks passed
@GiteaBot GiteaBot added this to the 28.0.0 milestone Aug 24, 2026
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 24, 2026
@silverwind
silverwind deleted the stylelint-ignore-at-rules branch August 24, 2026 20:07
silverwind added a commit to silverwind/gitea that referenced this pull request Aug 24, 2026
@silverwind
Merge branch 'main' of github.com:go-gitea/gitea into immutable
49db412 
* 'main' of github.com:go-gitea/gitea: (77 commits)
  chore: bump `declaration-strict-value` and reconfigure it (go-gitea#39080)
  fix(git): parse co-author trailers that are not RFC 5322 addresses (go-gitea#39076)
  fix(pull): name the head repository in default compare links (go-gitea#39075)
  chore: misc go 1.27 tweaks (go-gitea#39069)
  fix(packages/npm): use PathEscape for package name in tarball URL (go-gitea#39061)
  fix(attachments): enforce owning repository path (go-gitea#39048)
  chore(deps): update dependencies (go-gitea#39066)
  chore: add modelmigration to GO_DIRS (go-gitea#39072)
  chore: update Go to v1.27 (go-gitea#39068)
  [skip ci] Updated translations via Crowdin
  feat(diff): Add search and extension filter to diff sidebar (go-gitea#37068)
  fix(auth): record last sign-in on reverse proxy login (go-gitea#38672)
  fix(db): make paginated database reads always require "order" option (go-gitea#39017)
  fix(packages): restrict limited owner package access (go-gitea#39043)
  fix(api): enforce organization listing token scope (go-gitea#39041)
  fix(actions): enforce workflow badge token scope (go-gitea#39044)
  fix(repo): require organization owners for team access (go-gitea#39046)
  fix(org): hide limited organizations from restricted users (go-gitea#39047)
  [skip ci] Updated translations via Crowdin
  feat(actions)!: add RUN_RETENTION_DAYS to delete old action runs (go-gitea#38855)
  ...

# Conflicts:
#	modelmigration/migrations.go
#	modelmigration/v28/v349.go
#	modelmigration/v28/v349_test.go
#	services/release/release_test.go
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 26, 2026
@zjjhot
Merge branch 'main' of https://github.com/go-gitea/gitea
86bf465 
* 'main' of https://github.com/go-gitea/gitea:
  [skip ci] Updated translations via Crowdin
  chore: repo compare link (go-gitea#39088)
  fix(pull): keep the merged state in sync with git (go-gitea#39062)
  chore: anchor golangci exclusion paths to directories (go-gitea#39116)
  fix(asymkey): do not verify OpenPGP signatures with an SSH instance key, require git 2.18 (go-gitea#39073)
  fix(repo): prevent MarkAsBrokenEmpty when repository is being migrated (go-gitea#39091)
  [skip ci] Updated translations via Crowdin
  chore: bump `declaration-strict-value` and reconfigure it (go-gitea#39080)
  fix(git): parse co-author trailers that are not RFC 5322 addresses (go-gitea#39076)
  fix(pull): name the head repository in default compare links (go-gitea#39075)
  chore: misc go 1.27 tweaks (go-gitea#39069)
  fix(packages/npm): use PathEscape for package name in tarball URL (go-gitea#39061)
  fix(attachments): enforce owning repository path (go-gitea#39048)
  chore(deps): update dependencies (go-gitea#39066)
  chore: add modelmigration to GO_DIRS (go-gitea#39072)
  chore: update Go to v1.27 (go-gitea#39068)
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 26, 2026
@zjjhot
Merge branch 'main' into mainzjj
6805c4a 
* main:
  [skip ci] Updated translations via Crowdin
  chore: repo compare link (go-gitea#39088)
  fix(pull): keep the merged state in sync with git (go-gitea#39062)
  chore: anchor golangci exclusion paths to directories (go-gitea#39116)
  fix(asymkey): do not verify OpenPGP signatures with an SSH instance key, require git 2.18 (go-gitea#39073)
  fix(repo): prevent MarkAsBrokenEmpty when repository is being migrated (go-gitea#39091)
  [skip ci] Updated translations via Crowdin
  chore: bump `declaration-strict-value` and reconfigure it (go-gitea#39080)
  fix(git): parse co-author trailers that are not RFC 5322 addresses (go-gitea#39076)
  fix(pull): name the head repository in default compare links (go-gitea#39075)
  chore: misc go 1.27 tweaks (go-gitea#39069)
  fix(packages/npm): use PathEscape for package name in tarball URL (go-gitea#39061)
  fix(attachments): enforce owning repository path (go-gitea#39048)
  chore(deps): update dependencies (go-gitea#39066)
  chore: add modelmigration to GO_DIRS (go-gitea#39072)
  chore: update Go to v1.27 (go-gitea#39068)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes
@bircni bircni bircni approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/code-linting

Projects

None yet

Milestone

28.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@silverwind @lunny @bircni @GiteaBot