fix(actions): run every due schedule exactly once per occurrence

[bircni]

A schedule whose workflow could not be turned into a run returned an error out of the "Start actions schedule tasks" loop, so every remaining due schedule in that pass was skipped. The spec's next run time was not advanced either, so the same failure repeated once a minute, each time writing an admin notice.

Each spec is now advanced to its next occurrence before its run is created. A failure costs that one occurrence instead of the whole pass, and a failed update can no longer insert the same run twice. Failures are counted and reported once per pass, so the admin notice appears per occurrence rather than per minute.

Two related bugs in the same loop:

1. Offset paging re-queried next <= now after advancing the previous page, so above 50 due specs half of them were skipped until the next pass. It now pages by id.
2. A valid but unsatisfiable cron such as 0 0 30 2 * stores a negative next, which stayed due forever and created a run on every pass. Those specs are no longer inserted or selected.

The offending workflow itself is still rejected and logged rather than recorded as a failed run. Persisting a startup failure as a visible run is a separate change, since the same code path also covers cross-repo permission denials, where not persisting a run is intentional.

Fixes #39065

[Copilot]

Pull request overview

This PR adjusts the Actions scheduler cron pass so one broken scheduled workflow no longer aborts processing for all other due schedules, and adds regression coverage to ensure valid schedules still run while failing ones don’t block the pass.

Changes:

• Refactors the scheduler loop to process each due schedule spec independently, logging per-spec failures instead of aborting the full pass.
• Ensures schedule specs advance to their next occurrence even when run creation fails (to prevent repeated once-per-minute failures).
• Adds a unit test to verify a failing spec doesn’t prevent other specs from being scheduled and that both specs’ Next timestamps advance.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
services/actions/schedule_tasks.go	Refactors scheduled-run processing into a per-spec helper and changes failure handling so the cron pass continues.
services/actions/schedule_tasks_test.go	Adds a regression test ensuring one broken spec doesn’t block others and specs advance.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[silverwind]

cleaned up in 340f111.

[wxiaoguang]

You have refactored "db.Iterate" recently.

• fix(db): make paginated database reads always require "order" option - fix(db): make paginated database reads always require "order" option #39017

[wxiaoguang]

So, can you or your AI remember the useful information? If your AI can't remember, then human should remember.

[silverwind]

The best/only way to remember is to put it in docs.

[wxiaoguang]

Since you refuse to read and understand code, how do you know what should be put into docs? Whether the contents docs are still correct?

[bircni]

Replaced with db.Iterate — it already does this keyset walk