-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
feat(pull): add bypass-rules opt-in and expose scheduled auto-merge via API #38404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bircni
wants to merge
14
commits into
go-gitea:main
Choose a base branch
from
bircni:feat/pull-auto-merge-bypass
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+321
−151
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
bf49b39
feat(pull): add bypass-rules opt-in and expose scheduled auto-merge v…
bircni 7190623
Merge branch 'main' into feat/pull-auto-merge-bypass
bircni 9857be5
Merge branch 'main' into feat/pull-auto-merge-bypass
bircni 75baccd
Merge branch 'main' into feat/pull-auto-merge-bypass
bircni 4f1e085
Merge remote-tracking branch 'origin/main' into feat/pull-auto-merge-…
bircni 9fd26b6
adress comments
bircni 0c3f8b0
Merge remote-tracking branch 'origin/main' into feat/pull-auto-merge-…
bircni f2ac4c5
Merge branch 'main' into feat/pull-auto-merge-bypass
bircni ff28d08
fixes
bircni 0c80366
Merge remote-tracking branch 'origin/main' into feat/pull-auto-merge-…
bircni 2b55b16
fixes
bircni a031a0c
Merge branch 'main' into feat/pull-auto-merge-bypass
bircni a67c727
Merge remote-tracking branch 'origin/main' into feat/pull-auto-merge-…
bircni fe8077a
restyle
bircni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is a right design.
The pullMergeBoxInfoItemCollection is designed to be a flat list. Now, you just added the hacky patches to make it "indented" and "grouped".
It is very fragile.
I believe that "don't try to teach a duck to bark to make it become a dog".
If you need a new layout, design a proper data structure for it. Complex changes can be in a separate and dedicated PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems working because at the moment all callers to
AddErrorItemare oninfoProtectionBlockers, then the design is abused by this PR.But indeed
AddInfoItem/AddErrorItemare similar functions, the layout will break ifAddInfoItem/AddErrorItemare both called for the same section.We should avoid the unclear and fragile behaviors when designing the functions and methods. Do not bring surprises to developers.