Clarify model AIC chart units#124
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Clarifies the Models view’s charts by relabeling request-derived metrics as PRU-normalized (Premium Request Units) and adding an explanatory note so readers don’t conflate PRU quantities with actual request counts when comparing models.
Changes:
- Relabeled the daily average AIC chart from “per request” to “per PRU”.
- Renamed the daily volume chart from “Requests” to “PRUs” and adjusted series labeling accordingly.
- Added a note explaining that PRU quantities include model multipliers and aren’t directly comparable to raw request counts across models.
Show a summary per file
| File | Description |
|---|---|
| src/views/ModelsView.tsx | Updates chart titles/labels to PRU terminology and adds a clarifying note about PRU multipliers. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies the Models view so the average chart is presented as AICs per PRU rather than AICs per request. This avoids implying that PRU-normalized report quantities are directly comparable to actual request counts across models.
Changes
fix: clarify model AIC chart unitsTesting
npm run lint -- --quietnpm run testnpm run buildChecklist
npm run lint)