Remove ready_for_review triggers from workflows#3969
Open
mbg wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Pull request overview
This PR updates the repository’s GitHub Actions automation to stop relying on the pull_request.ready_for_review event as a workaround for workflow-triggering behavior, and instead aligns PR-creation flows with the newer “Approve workflow runs” UI mechanism.
Changes:
- Removes explicit
pull_request.typeslists (includingready_for_review) from multiple workflows and from the PR-check workflow generator. - Updates PR-creating automation to stop opening PRs as drafts (and removes the draft/ready toggling step).
- Adjusts automation messaging to instruct maintainers to approve workflow runs rather than marking PRs “ready for review”.
Show a summary per file
| File | Description |
|---|---|
pr-checks/sync.ts |
Updates generated PR-check workflow trigger configuration to avoid ready_for_review. |
.github/workflows/update-bundle.yml |
Stops creating update-bundle PRs as drafts. |
.github/workflows/test-codeql-bundle-all.yml |
Removes explicit pull_request.types list to avoid ready_for_review. |
.github/workflows/rebuild.yml |
Updates rebuild notification and removes draft/ready manipulation. |
.github/workflows/query-filters.yml |
Removes explicit pull_request.types list to avoid ready_for_review. |
.github/workflows/python312-windows.yml |
Removes explicit pull_request.types list and related commentary. |
.github/workflows/pr-checks.yml |
Removes explicit pull_request.types list and related commentary. |
.github/workflows/label-pr-size.yml |
Removes explicit pull_request.types list (note: also drops edited). |
.github/workflows/debug-artifacts-safe.yml |
Removes explicit pull_request.types list to avoid ready_for_review. |
.github/workflows/debug-artifacts-failure-safe.yml |
Removes explicit pull_request.types list to avoid ready_for_review. |
.github/workflows/codescanning-config-cli.yml |
Removes explicit pull_request.types list to avoid ready_for_review. |
.github/workflows/codeql.yml |
Removes explicit pull_request.types list and related commentary. |
.github/workflows/check-expected-release-files.yml |
Removes explicit pull_request.types list while keeping paths filtering. |
.github/update-release-branch.py |
Creates merge PRs as non-drafts and updates checklist wording to “approve workflow runs”. |
.github/actions/prepare-mergeback-branch/action.yml |
Creates mergeback PRs as non-drafts and updates checklist wording accordingly. |
Copilot's findings
Files excluded by content exclusion policy (56)
- .github/workflows/__all-platform-bundle.yml
- .github/workflows/__analysis-kinds.yml
- .github/workflows/__analyze-ref-input.yml
- .github/workflows/__autobuild-action.yml
- .github/workflows/__autobuild-direct-tracing-with-working-dir.yml
- .github/workflows/__autobuild-working-dir.yml
- .github/workflows/__build-mode-autobuild.yml
- .github/workflows/__build-mode-manual.yml
- .github/workflows/__build-mode-none.yml
- .github/workflows/__build-mode-rollback.yml
- .github/workflows/__bundle-from-nightly.yml
- .github/workflows/__bundle-from-toolcache.yml
- .github/workflows/__bundle-toolcache.yml
- .github/workflows/__bundle-zstd.yml
- .github/workflows/__cleanup-db-cluster-dir.yml
- .github/workflows/__config-export.yml
- .github/workflows/__config-input.yml
- .github/workflows/__cpp-deptrace-disabled.yml
- .github/workflows/__cpp-deptrace-enabled-on-macos.yml
- .github/workflows/__cpp-deptrace-enabled.yml
- .github/workflows/__diagnostics-export.yml
- .github/workflows/__export-file-baseline-information.yml
- .github/workflows/__extractor-ram-threads.yml
- .github/workflows/__global-proxy.yml
- .github/workflows/__go-custom-queries.yml
- .github/workflows/__go-indirect-tracing-workaround-diagnostic.yml
- .github/workflows/__go-indirect-tracing-workaround-no-file-program.yml
- .github/workflows/__go-indirect-tracing-workaround.yml
- .github/workflows/__go-tracing-autobuilder.yml
- .github/workflows/__go-tracing-custom-build-steps.yml
- .github/workflows/__go-tracing-legacy-workflow.yml
- .github/workflows/__init-with-registries.yml
- .github/workflows/__javascript-source-root.yml
- .github/workflows/__job-run-uuid-sarif.yml
- .github/workflows/__language-aliases.yml
- .github/workflows/__local-bundle.yml
- .github/workflows/__multi-language-autodetect.yml
- .github/workflows/__overlay-init-fallback.yml
- .github/workflows/__packaging-codescanning-config-inputs-js.yml
- .github/workflows/__packaging-config-inputs-js.yml
- .github/workflows/__packaging-config-js.yml
- .github/workflows/__packaging-inputs-js.yml
- .github/workflows/__remote-config.yml
- .github/workflows/__resolve-environment-action.yml
- .github/workflows/__rubocop-multi-language.yml
- .github/workflows/__ruby.yml
- .github/workflows/__rust.yml
- .github/workflows/__split-workflow.yml
- .github/workflows/__start-proxy.yml
- .github/workflows/__submit-sarif-failure.yml
- .github/workflows/__swift-autobuild.yml
- .github/workflows/__swift-custom-build.yml
- .github/workflows/__unset-environment.yml
- .github/workflows/__upload-ref-sha-input.yml
- .github/workflows/__upload-sarif.yml
- .github/workflows/__with-checkout-path.yml
- Files reviewed: 15/71 changed files
- Comments generated: 2
Comment on lines
3
to
4
| on: | ||
| pull_request: |
Comment on lines
113
to
117
| pr_url=$(gh pr create \ | ||
| --title "Update default bundle to $cli_version" \ | ||
| --body "$pr_body" \ | ||
| --assignee "$GITHUB_ACTOR" \ | ||
| --draft \ | ||
| ) |
henrymercer
reviewed
Jun 22, 2026
henrymercer
left a comment
Contributor
There was a problem hiding this comment.
One thing to fix, otherwise LGTM
Comment on lines
3
to
4
| on: | ||
| pull_request: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For CI-generated commits, we have used the workaround of creating draft PRs and marking them as "Ready for review" to trigger workflows using the
ready_for_reviewtype forpull_requestevents. This appears to no longer be necessary, because we can now click on the "Approve workflow runs" button in the UI instead.This PR removes the
ready_for_reviewtriggers we had specifically for this purpose (allowing us to revert to not specifying the event types at all, because the remaining list matches the default list). It also updates the automation where we create PRs to no longer create or mark them as drafts.Removing the
ready_for_reviewtriggers has the additional benefit that, for regular PRs, we no longer end up running the workflows twice if they have already run while the PR was a draft.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Environments:
How did/will you validate this change?
Validated this approach in a different repository which has the same scenario.
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist