Skip to content

refactor: move core internals into workspace package#154

Merged
jlitola merged 1 commit into
mainfrom
refactor-core-package-spec
Jun 5, 2026
Merged

refactor: move core internals into workspace package#154
jlitola merged 1 commit into
mainfrom
refactor-core-package-spec

Conversation

@jlitola

@jlitola jlitola commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • move transport-neutral API clients, PKCE helpers, request/header/telemetry utilities, and related tests into private @githits/core-internal
  • keep CLI-local auth storage, keychain, browser, prompt, update-check, and storage-backed token manager code in the root CLI layer
  • configure root Bunup build to bundle private workspace source while externalizing runtime dependencies and preventing private markers in published artifacts

Verification

  • bun install --frozen-lockfile
  • bun run typecheck
  • bun test
  • bun run lint
  • bun run format:check
  • git diff --check
  • bun run build
  • npm pack --dry-run
  • bun run smoke:mcp
  • bun run smoke:cli
  • dist private-marker scan for @githits/core-internal, @githits/mcp, core-internal, and workspace:
  • stale root import scan for moved service/shared/auth paths
  • code-reviewer pass: no findings

Move transport-neutral clients, shared request helpers, PKCE utilities, and core service tests into the private @githits/core-internal package. Keep CLI-local storage, keychain, prompt, browser, and token-manager integrations in the root CLI layer while importing moved code through the package boundary.
@jlitola jlitola merged commit 8a413df into main Jun 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant