Skip to content

fix(misc): skip missing ship templates in global build imports#240

Open
ggmolly wants to merge 1 commit intomainfrom
fix/gamedata-missing-ships
Open

fix(misc): skip missing ship templates in global build imports#240
ggmolly wants to merge 1 commit intomainfrom
fix/gamedata-missing-ships

Conversation

@ggmolly
Copy link
Copy Markdown
Owner

@ggmolly ggmolly commented Feb 23, 2026

Summary

  • Prevent startup data updates from failing when global build metadata references ship templates absent in the selected region.
  • Keep region-specific ship datasets authoritative by skipping unmapped pool/build-time rows instead of aborting the transaction.
  • Add regression coverage for template 10400031 to ensure missing-template handling stays non-fatal.

Changes

  • Updated importPoolsSQLC to warn and continue when SetShipPoolID affects zero rows.
  • Refactored build-time application through applyBuildTimes(...) and made zero-row updates warn-and-skip.
  • Added end-of-step warning summaries for skipped pool/build-time mappings.
  • Added TestApplyBuildTimesSkipsMissingShipTemplate in internal/misc/update_data_sqlc_test.go.

@ggmolly ggmolly added type/bug Defect or incorrect behavior area/assets Assets/extracted data type/test Test additions or fixes labels Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/assets Assets/extracted data type/bug Defect or incorrect behavior type/test Test additions or fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant