ref(remix): Use @sentry/conventions#21497
Merged
Merged
Conversation
mydea
marked this pull request as ready for review
June 12, 2026 10:59
mydea
requested review from
chargome and
nicohrubec
and removed request for
a team
June 12, 2026 10:59
chargome
reviewed
Jun 12, 2026
chargome
left a comment
chargome
left a comment
Member
There was a problem hiding this comment.
Is this generally the way how we should consume @sentry/conventions? Seems a bit cumbersome to set it up this way for all packages?
mydea
force-pushed
the
feat/use-sentry-conventions-remix
branch
from
June 12, 2026 11:24
9582eec to
92a1d8f
Compare
mydea
changed the base branch from
develop
to
feat/use-sentry-conventions-build-infra
June 12, 2026 11:26
mydea
marked this pull request as draft
June 12, 2026 11:26
mydea
force-pushed
the
feat/use-sentry-conventions-build-infra
branch
from
June 12, 2026 11:33
625467a to
2a83a9f
Compare
mydea
force-pushed
the
feat/use-sentry-conventions-remix
branch
from
June 15, 2026 08:11
92a1d8f to
b5bfd9a
Compare
mydea
changed the base branch from
feat/use-sentry-conventions-build-infra
to
develop
June 15, 2026 08:11
Contributor
size-limit report 📦
|
mydea
force-pushed
the
feat/use-sentry-conventions-remix
branch
2 times, most recently
from
June 17, 2026 08:56
a4e4294 to
f23bdd1
Compare
Source span/attribute keys from `@sentry/conventions` as a regular dependency (externalized at build time, resolved at runtime). No functional change. Maps the `@sentry/conventions/attributes` subpath in the shared TS config for the repo's `node` moduleResolution type builds. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
force-pushed
the
feat/use-sentry-conventions-remix
branch
from
June 17, 2026 09:09
f23bdd1 to
fed28de
Compare
mydea
marked this pull request as ready for review
June 17, 2026 09:13
Contributor
|
👋 @nicohrubec — Please review this PR when you get a chance! |
nicohrubec
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches
@sentry/remixto source span/attribute keys from@sentry/conventions, added as a regular runtimedependencyand externalized at build time (resolved at runtime by the consumer's installed copy). No functional change — the attribute values are identical.Part of splitting the larger
@sentry/conventionsmigration into per-package PRs.Ref: #20982